fix(@angular/build): correct Vitest builder watch mode execution #30966
+50
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3f47f37 to
1672128
Compare
bc782d3 to
e4ba249
Compare
The experimental Vitest-based unit test builder did not always correctly re-run tests in watch mode. This commit refactors the Vitest executor to provide more accurate watch mode behavior by: - Disabling Vitest's internal file watcher (`watch: null`) to make the Angular builder's watcher the single source of truth. - Triggering a test run via `vitest.rerunTestSpecifications()` within the `execute` method after each incremental build is complete.
The Vitest-based unit test builder created temporary output directories within `dist/test-out` for each run but did not remove them upon completion. This led to an accumulation of orphaned directories, consuming unnecessary disk space. This commit introduces robust cleanup logic to the `VitestExecutor` by: - Deleting the temporary output directory during graceful shutdown using the `asyncDispose` method. - Registering a `SIGINT` process handler to ensure the directory is also removed during forceful interruptions, such as when a user presses `Ctrl-C` in watch mode.
e4ba249 to
b9c49e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The experimental Vitest-based unit test builder did not always correctly re-run tests in watch mode.
This commit refactors the Vitest executor to provide more accurate watch mode behavior by:
watch: null) to make the Angular builder's watcher the single source of truth.vitest.rerunTestSpecifications()within theexecutemethod after each incremental build is complete.