Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

aded app protocol to httpBackend.js #1120

Closed
wants to merge 2 commits into from
Closed

Conversation

beatscode
Copy link

Ng-view was not updating when a routeChange occurred.

@rudylattae
Copy link

Thanks I needed this badly.

@mhevery
Copy link
Contributor

mhevery commented Sep 5, 2012

Thanks for your contribution! In order for us to be able to accept it, we ask you to sign our CLA (contributor's license agreement).

CLA is important for us to be able to avoid legal troubles down the road.

For individuals (a simple click-through form):
http://code.google.com/legal/individual-cla-v1.0.html

For corporations (print, sign and scan+email, fax or mail):
http://code.google.com/legal/corporate-cla-v1.0.html

@mhevery
Copy link
Contributor

mhevery commented Sep 12, 2012

ping??? we need the CLA signed, otherwise we can not merge this in

@beatscode
Copy link
Author

I signed the form already. I used the form at the bottom.
On Sep 11, 2012, at 8:36 PM, Miško Hevery notifications@github.com wrote:

ping??? we need the CLA signed, otherwise we can not merge this in


Reply to this email directly or view it on GitHub.

@pkozlowski-opensource
Copy link
Member

It is a pity that there are no associated tests for this PR... There are very explicit test for the file:// protocol...

@jbdeboer
Copy link
Contributor

This PR is missing tests so cannot be merged in its current state. I'm closing this PR for now; please re-open it when it has tests.

@jbdeboer jbdeboer closed this Jan 17, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants