Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Providing an example of customizing actions on $resource factory. #11860

Closed
wants to merge 1 commit into from
Closed

Providing an example of customizing actions on $resource factory. #11860

wants to merge 1 commit into from

Conversation

yilinglu
Copy link
Contributor

No description provided.

@gkalpak
Copy link
Member

gkalpak commented May 12, 2015

Interesting (I had never noticed that).
I think we should properly document $resourceProvider instead.

@gkalpak
Copy link
Member

gkalpak commented May 19, 2015

@yilinglu, would you be interested in submitting a PR, properly documenting the $resourceProvider ?

By "properly documenting", I mean adding ngdoc comments (to the provider and its methods/properties), so that $resourceProvider appears in the docs as a separate entry (under ngResource -> provider).
To get an idea of what I am talking about, you can take a look at any other documented provider (e.g. $routeProvider).

@yilinglu
Copy link
Contributor Author

OK. I will write it up and submit a PR in the next couple of days.

@gkalpak
Copy link
Member

gkalpak commented May 19, 2015

Awesome, thx !
Feel free to ping me if you need anything (or if you want me to take a look when it's ready).

@yilinglu
Copy link
Contributor Author

PR submitted. Please review.
Thanks.

@gkalpak
Copy link
Member

gkalpak commented May 21, 2015

Closing in favor of #11910.

@gkalpak gkalpak closed this May 21, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants