This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($injector): workaround for MS Edge class detection #13697
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@petebacondarwin can you take a look at this? Did some small so we do not have to keep track of what browser supports what ES6 feature |
7652275 to
221b3be
Compare
|
|
||
| if (support.classes) { | ||
| it('should be possible to instantiate ES6 classes', function() { | ||
| // Only Chrome (not even the FF we use) supports ES6 classes. | ||
| if (!/chrome/i.test(navigator.userAgent)) return; |
There was a problem hiding this comment.
@lgalfaso should this chrome check be removed?
|
One question, otherwise LGTM |
Fix for MS Edge class detection Closes: angular#13697
| return typeof func === 'function' | ||
| && /^class\s/.test(Function.prototype.toString.call(func)); | ||
| && /^(?:class\s|constructor\()/.test(Function.prototype.toString.call(func)); |
There was a problem hiding this comment.
Actually I think we need to test for constructor( only if we are on Edge, since it is possible that someone might have a function actually called constructor.
There was a problem hiding this comment.
@lgalfaso explained that:
(function constructor() {}).toString() === "function constructor() {}"So this is not an issue
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for MS Edge class detection