Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(guide/migration): add notes for migrating from 1.4 to 1.5 #13808

Closed
wants to merge 3 commits into from

Conversation

gkalpak
Copy link
Member

@gkalpak gkalpak commented Jan 20, 2016

Closes #13474

A few notes:

  • It seemed more clear to me to group the changes by module (instead of by "subject", e.g. forms, server requests etc).
  • Changes made after 1.5.0-rc.1 are not included (yet).

@gkalpak
Copy link
Member Author

gkalpak commented Jan 20, 2016

Do you think it needs more (any) code examples ? The changes sounded straightforward enough to me to warrant code examples, but all previous migration notes are full of code 😕

@gkalpak gkalpak force-pushed the docs-guide-migrate-to-1.5 branch from 4a05ec2 to 5e1d603 Compare January 20, 2016 14:02
### Filters (`orderBy`)

Due to [2a85a634](https://github.com/angular/angular.js/commit/2a85a634f86c84f15b411ce009a3515fca7ba580),
passing a non-array-like value (other than `undefined` or `null`) through the `orderBy` filter will
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be helpful to the reader to quickly enumerate some of the things that are array-like, such as strings and DOM nodes, at this point so that they can be reassured.

@petebacondarwin
Copy link
Contributor

A couple of minor comments. But generally looks good.


# Migrate from 1.4 to 1.5

Angular 1.5 takes a big step towards enabling developers to prepare themselves for a smoother
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be shortened to .. a big step towards preparing developers for a smoother ..

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@gkalpak gkalpak closed this in 16bcdcb Jan 26, 2016
@gkalpak gkalpak changed the title docs(guide#migration): add notes for migrating from 1.4 to 1.5 docs(guide/migration): add notes for migrating from 1.4 to 1.5 Jan 26, 2016
@gkalpak
Copy link
Member Author

gkalpak commented Jan 26, 2016

Merged. Thx @petebacondarwin and @Narretz for the reviews.

@gkalpak gkalpak deleted the docs-guide-migrate-to-1.5 branch January 27, 2016 13:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants