Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(error/inprog): describe your change... #13896

Closed
wants to merge 1 commit into from

Conversation

smithl
Copy link
Contributor

@smithl smithl commented Jan 30, 2016

small typo: a -> an (before $apply)

small typo: a -> an (before $apply)
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@gkalpak
Copy link
Member

gkalpak commented Jan 30, 2016

It depends on how you read $apply. For some it is "dollar apply", for others (including me) it's just "apply". I'd merge this, if only the CLA was signed... 😉

@cynthia-wi
Copy link

@gkalpak @smithl I think the best solution would be a(n) $apply.

@smithl
Copy link
Contributor Author

smithl commented Jan 30, 2016

@gkalpak @rerdos - Fair enough, I was concerned that it wasn't consistent with the two other instances on the same page, where it says "an apply." I am now noticing one more example on the same page where its "within a $apply/$digest" - this one should probably be changed as well.

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@gkalpak
Copy link
Member

gkalpak commented Jan 31, 2016

I fixed the other occurrence while merging. Thx !
Backported to v1.4.x as afb298b.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants