This repository was archived by the owner on Apr 12, 2024. It is now read-only.
docs(guide/Components): add note to output events #14365
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add additional line from example which demonstrates using the snake cased attribute binding in parent component template. Add note clarifying camelCase to snake-case requirement to use the Output event callback feature.
|
Thanks for the PR. I will add the additional code example and a less verbose HTML comment about snake case. This is nothing new for components, binding names have always been camelCase in the definition and snake case in templates. These are also not "real" events, but the usual & bindings which execute an expression in the parent (input) scope. This is different from angular2. (These bindings don't bubble up for example). |
Narretz
pushed a commit
that referenced
this pull request
Apr 7, 2016
…note Add additional line from example which demonstrates using the snake cased attribute binding in parent component template. Add note clarifying camelCase to snake-case requirement to use the Output binding callback feature. Closes #14365
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Docs clarification and additional line added to example
What is the current behavior? (You can also link to an open issue here)
Currently the example for using output events doesn't include an attribute binding example from a parent component/directive. Others are finding the lack of example confusing here: http://stackoverflow.com/questions/35559354/the-in-angular-1-5-components/35560611
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements
Other information: