This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Ng model options fix #15401
Closed
Ng model options fix #15401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkalpak
approved these changes
Nov 17, 2016
| @@ -480,15 +480,37 @@ describe('ngModelOptions', function() { | |||
| expect($rootScope.checkbox).toBeUndefined(); | |||
There was a problem hiding this comment.
Not directly related to this PR, but checkbox should be name (here and above).
| }); | ||
|
|
||
|
|
||
| it('should trigger immediately for the default event if not listed in the debounce list', |
There was a problem hiding this comment.
This is not specific to the default event. The bug affected any event that was not listed in debounce as long as debounce was an object and didn't contain the catch-all default. I wouldn't mind adding one more assertion to the test, like this:
var inputElm = helper.compileInput(
'<input type="text" ng-model="name" name="alias" ' +
'ng-model-options="{' +
- 'updateOn: \'default blur\', ' +
+ 'updateOn: \'default blur foo\', ' +
'debounce: { blur: 5000 }' +
'}"' +
'/>');
helper.changeInputValueTo('a');
expect($rootScope.name).toEqual('a');
+ helper.changeInputValueTo('b');
+ browserTrigger(inputElm, 'foo');
+ expect($rootScope.name).toEqual('b');
});There was a problem hiding this comment.
The trouble with the test as you suggest is that the default event is triggered by helper.changeInputValueTo('b') in any case. And so this would pass even if the foo event had a weird truthy timeout.
7fde402 to
1adb3bd
Compare
ellimist
pushed a commit
to ellimist/angular.js
that referenced
this pull request
Mar 15, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change?
Please check if the PR fulfills these requirements
Other information: