This repository was archived by the owner on Apr 12, 2024. It is now read-only.
docs($rootScope.Scope): clarify $watchGroup "oldValues" argument #16005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkalpak
reviewed
May 22, 2017
src/ng/rootScope.js
Outdated
| * | ||
| * $scope.v2 = 'b' | ||
| * | ||
| * // v1 hasn't changed since the it became `'a'`, therefore its oldValue is still `undefined` |
This should help to prevent issues such as angular#8671, angular#12452, angular#16004. Closes angular#12643
|
@gkalpak I think we should still merge this into 1.6.x Wdyt? |
3 tasks
|
I agree. It is good to go for 1.6.x. |
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help to prevent issues such as #8671, #12452, #16004.
Closes #12643
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
docs
What is the current behavior? (You can also link to an open issue here)
unclear docs
What is the new behavior (if this is a feature change)?
hopefully clearer docs :)
Does this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements
Other information: