Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

benchmarks - remove no longer applicable, add $watchCollection #16063

Merged
merged 2 commits into from
Jun 28, 2017

Conversation

jbedard
Copy link
Collaborator

@jbedard jbedard commented Jun 20, 2017

Removing

  • cases accessing constructor that previously had extra "security" applied
  • the bmPeWatchLiteral directive that was making literals $watch-able, now they can be watched normally

Adding

  • some $watchCollection tests

Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 LGTM 🎉
(with the typo fixed)

<span bm-pe-watch-collection="[rowIdx, row, num0, str0, date0, obj, g, h, i, j, k, l, m, n, o, p]"></span>
<span bm-pe-watch-collection="{a: rowIdx, b: row, c: num0, d: str0, e: date0, f: obj, g: g, h: h, i: i, j: j, k: k, l: l, m: m, n: n, o: o, p: p}"></span>

<!-- primative/valueOf-compatible -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

primative --> primitive

@jbedard jbedard force-pushed the benchmarks-watchcollection branch from 90ffe43 to ba26c20 Compare June 28, 2017 03:48
@jbedard jbedard merged commit a772b94 into angular:master Jun 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants