This repository was archived by the owner on Apr 12, 2024. It is now read-only.
refactor($parse): do not pass scope,locals to interceptor fns #16091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkalpak
approved these changes
Jul 11, 2017
|
@jbedard can you please add the info from the PR to the commit message? This will be helpful for the next person who works on this code. While it's a refactor because it doesn't touch a public API, by including tests we change the expectations for how the internals should work. |
All internal use of interceptors are for things such as data conversion/normalizing, never reading state from the scope/locals. This is the intended use and makes interceptors more like filters (which receive only the input value + args, no scope/locals).
701bb70 to
960ceb1
Compare
|
Updated the commit message. |
|
I'd also vote to only put this into 1.7 since it does change an internal but publicly accessible API |
|
1.7 is fine with me |
|
Commit msg look ok before merging? |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After @lgalfaso's comment I thought it would be a good idea to remove these params from interceptors. All the internal uses of interceptors are for doing things like data conversion/normalizing, never reading state out of the scope/locals. I think this is the intended use, and makes them like filters (which receive the input value + args).
Note that scope/locals still get passed through to the expression being wrapped/intercepted, it's just the interceptor-fn itself that now only receives the value.