Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(ngRepeat): redundant "and" on line 77 #16657

Closed
wants to merge 1 commit into from
Closed

docs(ngRepeat): redundant "and" on line 77 #16657

wants to merge 1 commit into from

Conversation

john-mantas
Copy link
Contributor

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
docs update

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change?

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Fix/Feature: Docs have been added/updated
  • Fix/Feature: Tests have been added; existing tests pass

Other information:

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@john-mantas
Copy link
Contributor Author

I signed it!

@john-mantas john-mantas closed this Aug 4, 2018
@john-mantas john-mantas reopened this Aug 4, 2018
@gkalpak
Copy link
Member

gkalpak commented Aug 6, 2018

Thx for the PR.
It seems that the CLA is still not verified. Have you signed it with the same address that is associated with the commit?

@john-mantas
Copy link
Contributor Author

I made the edit and commit from github, maybe this is the problem? Though i have used the same address for the cla with the one i'm using on github.

When i click on my name under the commit, i get the message "No commits found for "john-mantas"...", maybe i did something wrong, sorry for the inconvenience this was my first PR.

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Aug 6, 2018
@john-mantas
Copy link
Contributor Author

Googlebot wanted me to say sorry to accept my cla? :)
This seems ok now, please inform me if there are more issues with my PR!

PS. Why does googlebot post messages twice?

@gkalpak gkalpak closed this in ad7ea95 Aug 7, 2018
gkalpak pushed a commit that referenced this pull request Aug 7, 2018
@gkalpak
Copy link
Member

gkalpak commented Aug 7, 2018

Thx, @john-mantas! It looks good now.
(Not sure why @googlebot posts twice. I suspect it's @googlebot and its evil twin, but I don't have proof. Yet...)

kfeinUI pushed a commit to kfeinUI/angular.js that referenced this pull request Aug 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants