Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Spelling fixes for documentation and JSDoc corrections #3280

Closed
wants to merge 1 commit into from
Closed

Spelling fixes for documentation and JSDoc corrections #3280

wants to merge 1 commit into from

Conversation

carldanley
Copy link
Contributor

I fixed a lot of spelling errors as I was going through some documentation tonight. Also corrected a few JSDoc's that didn't have parameter specifications or had incorrect spec's.

@carldanley
Copy link
Contributor Author

I don't think the Travis CI build failed from me but I could be wrong. Let me know if there's something I can do to help this move along.

@pkozlowski-opensource
Copy link
Member

  • PR is rebased against recent master
  • PR is squashed into one commit per logical change
  • PR's commit messages are descriptive and allows us to autogenerate release notes (required commit message format)
  • All changes requested in review have been implemented

@pkozlowski-opensource
Copy link
Member

@carldanley Thnx for all the fixes, much appreciated! Would you mind squashing all the commits into one add changing the commit message to follow our convention? This would speed up things! Thnx!

…ameters

* overriden -> overwritten
* Jsonified -> JSON-ified
* minfication -> minification
* defered -> deferred
* tempalte -> template
* my:DiRective -> my:Directive
* suffixe -> suffix
* revesed -> reversed
* itwhich -> it
* techniqueue -> technique
* vody -> body
* finshes -> finishes
* added a missing JSDoc parameter for `src/ng/location.js`
* added missing parameter names for JSDoc in `src/ngScenario/Future.js` and `src/ngScenario/ObjectModel.js`
* renamed a JSDoc paramert from what was probably the old variable name in `src/ngScenario/ObjectModel.js`

Squashed commit of the following:

commit 2de45ffd4636e54877275cc323c50d3de4fe69d9
Merge: faf38db e14e219
Author: Carl Danley <carldanley@gmail.com>
Date:   Mon Jul 22 10:45:39 2013 -0400

    Merge branch 'master' of github.com:angular/angular.js

commit faf38dbf2d8e0130600c07f26ed4fd7e3e04b603
Author: Carl Danley <carldanley@gmail.com>
Date:   Thu Jul 18 23:01:37 2013 -0400

    more spelling and JSDoc fixes

commit 06ebbf364938e6f8c430c15870245388a3277947
Author: Carl Danley <carldanley@gmail.com>
Date:   Thu Jul 18 22:59:32 2013 -0400

    some more spelling fixes. Fixed another JSDoc with incorrect parameter specifications

commit 77f5f94e2022231da96522113fc3fa78d118bb48
Author: Carl Danley <carldanley@gmail.com>
Date:   Thu Jul 18 22:48:35 2013 -0400

    fixed JSDoc for function so `replace` is properly described

commit e9f581384795da3628b65c1afdc80abab24e3f28
Author: Carl Danley <carldanley@gmail.com>
Date:   Thu Jul 18 22:47:02 2013 -0400

    small spelling errors that have been fixed.
@carldanley
Copy link
Contributor Author

This commit should now match your message conventions but please let me know if I've missed anything.

@pkozlowski-opensource
Copy link
Member

Landed as 258e986 in master after conflict resolution. But a cherry-pick to v1.0.x is rather messy so let's stick with master changes only. Thnx!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants