I see the router has been factored out of the core of angular. Is there any commentary on that anywhere?

@richardcrichardc there's a discussion about the move here: #2804

PR Checklist (Minor Feature)

• Contributor signed CLA now or in the past (if you just signed, leave a comment here with your real name for cross reference)
• Feature improves existing core functionality
• API is compatible with existing Angular apis and relevant standards (if applicable)
• PR doesn't contain a breaking change
• PR contains unit tests
• PR contains e2e tests (if suitable)
• PR contains documentation update
• PR passes all tests on Travis (sanity)
• PR passes all tests on ci.angularjs.org (cross-browser compatibility)
• PR is rebased against recent master
• PR is squashed into one commit per logical change
• PR's commit messages are descriptive and allows us to autogenerate release notes (required commit message format)
• All changes requested in review have been implemented

@richardcrichardc - when you have a moment, can you read our commit message guidelines. See above. It will make it easier to merge your PRs.

@petebacondarwin

How is this:

feat($routeProvider): Route can be a callback function

The route parameter of $routeProvider.when() and $routeProvider.otherwise()
can now be a callback function so that more elaborate routing logic can be
used without replacing the standard router.

If this is ok. Can you suggest the best way to get this into the pull request. Will a dummy commit, i.e. no actual real change, with the commit message do the job, or should I do something different.

git commit --amend ...
git push -f

On 28 July 2013 22:21, Richard Collins notifications@github.com wrote:

@petebacondarwin https://github.com/petebacondarwin

How is this:

feat($routeProvider): Route can be a callback function

The route parameter of $routeProvider.when() and $routeProvider.otherwise()
can now be a callback function so that more elaborate routing logic can be
used without replacing the standard router.

If this is ok. Can you suggest the best way to get this into the pull
request. Will a dummy commit, i.e. no actual real change, with the commit
message do the job, or should I do something different.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/3359#issuecomment-21691360
.

I think this has been obsoleted by making route a separate module.