Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Update dev_guide.services.$location.ngdoc #3555

Closed
wants to merge 1 commit into from
Closed

Update dev_guide.services.$location.ngdoc #3555

wants to merge 1 commit into from

Conversation

zivc
Copy link
Contributor

@zivc zivc commented Aug 13, 2013

Added a point about using Angular in the root of a domain with HTML5 urls and then trying to link to external paths within the same directory.

Please see the following:
Original issue: #3520 (comment)
Solution: http://fiddle.jshell.net/fgHf6/3/

Added a point about using Angular in the root of a domain with HTML5 urls and then trying to link to external paths within the same directory.

Please see the following:
Original issue: #3520 (comment)

Solution: http://fiddle.jshell.net/fgHf6/3/
@mary-poppins
Copy link

Thanks for the PR!

  • Contributor signed CLA now or in the past
    • If you just signed, leave a comment here with your real name
  • PR's commit messages follow the commit message format

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@zivc
Copy link
Contributor Author

zivc commented Aug 13, 2013

Just signed the CLA, name is Ashley Taylor

@petebacondarwin
Copy link
Contributor

@zivc - Can you provide a running example of your suggestion?

@zivc
Copy link
Contributor Author

zivc commented Sep 5, 2013

@petebacondarwin http://angular.zi.vc/ - In this example, when using an Angular app and HTML5 URLs at the root of a domain - AngularJS tries to route everything even when it's not defined - probably because of our route on /. Yet, http://angular.zi.vc/other/ is an actual static path on the domain.

See the jsfiddle in the OP for a solution. I was hoping we could get the documentation updated to reflect this.

@petebacondarwin
Copy link
Contributor

Oops sorry. I didn't notice the fiddle. OK. I think the wording could be improved...

petebacondarwin pushed a commit that referenced this pull request Sep 18, 2013
When using Angular in the root of a domain with HTML5 URLs
where there are links to external paths within the same directory,
the `otherwise` route handler will catch these external files.
This can be fixed by prefixing '.' onto the links to URLs that should
be handled by angular routing.

Original Issue: #3520
Example of Fix: http://fiddle.jshell.net/fgHf6/3/

Closes #3555
@petebacondarwin
Copy link
Contributor

Merged with mods. Thanks @zivc.

jamesdaily pushed a commit to jamesdaily/angular.js that referenced this pull request Sep 25, 2013
When using Angular in the root of a domain with HTML5 URLs
where there are links to external paths within the same directory,
the `otherwise` route handler will catch these external files.
This can be fixed by prefixing '.' onto the links to URLs that should
be handled by angular routing.

Original Issue: angular#3520
Example of Fix: http://fiddle.jshell.net/fgHf6/3/

Closes angular#3555
jamesdaily pushed a commit to jamesdaily/angular.js that referenced this pull request Jan 27, 2014
When using Angular in the root of a domain with HTML5 URLs
where there are links to external paths within the same directory,
the `otherwise` route handler will catch these external files.
This can be fixed by prefixing '.' onto the links to URLs that should
be handled by angular routing.

Original Issue: angular#3520
Example of Fix: http://fiddle.jshell.net/fgHf6/3/

Closes angular#3555
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants