feat(cdk-experimental/ui-patterns): accordion #31034
Open
+637
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wagnermaciel
approved these changes
May 6, 2025
wagnermaciel
reviewed
May 6, 2025
| expect(panelPatterns[1].hidden()).toBeFalse(); | ||
| }); | ||
|
|
||
| it('collaps a panel without affecting other panels.', () => { |
wagnermaciel
reviewed
May 6, 2025
|
|
||
| /** The keydown event manager for the accordion trigger. */ | ||
| keydown = computed(() => { | ||
| const manager = new KeyboardEventManager() |
There was a problem hiding this comment.
nit: return new Keyboard...
wagnermaciel
approved these changes
May 6, 2025
wagnermaciel
reviewed
May 6, 2025
| expanded = computed(() => this.expansionControl.visible()); | ||
|
|
||
| /** Id of the accordion panel controlled by the trigger. */ | ||
| controls = computed(() => this.expansionControl.controls()); |
There was a problem hiding this comment.
controls sounds like this contains an array of controllers for this accordion. We should use a different name for this (both here and for the ExpansionControl class). Something like expansionPanelId to clearly indicate what this is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.