Skip to content

fix(material/button-toggle): skip keyboard navigation when modifier key is pressed #31651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2025

Conversation

adolgachev
Copy link
Contributor

@adolgachev adolgachev commented Aug 5, 2025

Fixes b/368710444 where button toggle captures keyboard shortcuts like back button due to not checking for modifier key.

@adolgachev adolgachev changed the title Toggle nav fix(material/button-toggle): skip keyboard navigation when modifier key is pressed Aug 5, 2025
@adolgachev adolgachev added Accessibility This issue is related to accessibility (a11y) target: minor This PR is targeted for the next minor release dev-app preview When applied, previews of the dev-app are deployed to Firebase action: global presubmit The PR is in need of a google3 global presubmit labels Aug 5, 2025
Copy link

github-actions bot commented Aug 5, 2025

Deployed dev-app for 9595b6c to: https://ng-dev-previews-comp--pr-angular-components-31651-dev-d9jbz68e.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@adolgachev adolgachev marked this pull request as ready for review August 6, 2025 16:32
@adolgachev adolgachev requested a review from a team as a code owner August 6, 2025 16:32
@adolgachev adolgachev requested review from andrewseguin and wagnermaciel and removed request for a team August 6, 2025 16:32
@adolgachev adolgachev added action: review The PR is still awaiting reviews from at least one requested reviewer and removed action: global presubmit The PR is in need of a google3 global presubmit labels Aug 6, 2025
@andrewseguin andrewseguin added the action: merge The PR is ready for merge by the caretaker label Aug 6, 2025
@adolgachev adolgachev removed the request for review from wagnermaciel August 6, 2025 16:52
@adolgachev adolgachev merged commit 11ad09f into angular:main Aug 6, 2025
41 checks passed
@adolgachev adolgachev deleted the toggle-nav branch August 6, 2025 16:53
demanr pushed a commit to demanr/components that referenced this pull request Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker action: review The PR is still awaiting reviews from at least one requested reviewer area: material/button-toggle dev-app preview When applied, previews of the dev-app are deployed to Firebase target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants