Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

build: update to Angular/RxJS v6.0.0 release #200

Merged
merged 1 commit into from
Jul 24, 2018
Merged

Conversation

wardbell
Copy link
Contributor

@wardbell wardbell commented May 4, 2018

No description provided.

@wardbell wardbell requested a review from IgorMinar May 4, 2018 19:38
Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix the peer dep declaration - the rest looks good.

package.json Outdated
"@angular/common": "^6.0.0",
"@angular/core": "^6.0.0",
"@angular/http": "^6.0.0",
"rxjs": "^6.1.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a breaking change because all the client apps would be forced to update to rxjs 6.1.0 - please change this to ^6.0.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for delay. I didn't see this coming. Fixing.

@wardbell wardbell merged commit 35f17fe into master Jul 24, 2018
@wardbell wardbell deleted the release-0-6-1 branch July 24, 2018 00:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants