Skip to content

docs: update links angular.io -> angular.dev #1841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2024
Merged

docs: update links angular.io -> angular.dev #1841

merged 1 commit into from
May 26, 2024

Conversation

davidlj95
Copy link

@davidlj95 davidlj95 commented May 23, 2024

As part of Angular v18 release, Angular.dev is now the new reference documentation site.

This PR updates every angular.io link I could find on the repo

Therefore tackles #1642 here too

The PR targets next-major-release/v18 branch as some links have already been updated in v18 PR #1830 . Once gets merged, will rebase so rest of links are fixed. Or can merge it into #1830 buut maybe that would make the PR too big? I can also cherry pick my commit on top of main to merge it before (as long as no other link gets changed in that PR to avoid conflicts)

Copy link

nx-cloud bot commented May 26, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit bfac844. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


🟥 Failed Commands
nx-cloud record -- yarn format-check
✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

Copy link
Member

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this!

@@ -44,7 +44,7 @@ export default createESLintRule<Options, MessageIds>({
allowStylePrecedenceDuplicates: {
type: 'boolean',
default: DEFAULT_OPTIONS.allowStylePrecedenceDuplicates,
description: `Whether or not Angular style precedence is allowed as an exception to the rule. See https://angular.io/guide/style-precedence#style-precedence`,
description: `Whether or not Angular style precedence is allowed as an exception to the rule. See https://angular.dev/guide/templates/class-binding#styling-precedence`,
Copy link
Member

@JamesHenry JamesHenry May 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a shame this link is so inferior to the previous one currently. I've reported it to the Angular Team, but yeah the old links no longer work at all it seems as of today.

Update: apparently they are having service worker issues and the old links are supposed to be working

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JamesHenry JamesHenry marked this pull request as ready for review May 26, 2024 16:36
@JamesHenry JamesHenry merged commit f88eff6 into angular-eslint:next-major-release/v18 May 26, 2024
5 of 6 checks passed
@davidlj95 davidlj95 deleted the stacked/angular.io-to-angular.dev branch May 26, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants