fix(eslint-plugin): fix placement of lifecycle interface for subclasses #1965
Conversation
|
I have manually tested the fix on my project but I wonder whether there is any possibility to test --fix with automated tests. |
There was a problem hiding this comment.
@al-mart Yes please take a look at existing rules, there are many cases where auto fixing is tested.
convertAnnotatedSourceToFailureCase() is our utility to allow for a nice visual way to write assertions about errors.
annotatedSource is with the errors, annotatedOutput is after the fixes are applied
|
Thank you. Will add the missing test cases accordingly. |
|
@al-mart Following up on this one please |
|
Yeah, sorry was on vacation without the pc. Will add the PR with tests tomorrow. |
|
@JamesHenry added the missing test case, the problem is only occurring when there is a class extension but no interface implementation at all. |
f8206c8 to
6c0006f
Compare
6c0006f to
08d49b4
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 6906477. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 7 targetsSent with 💌 from NxCloud. |
|
@al-mart I have updated the branch, will you be addressing the CI failures please? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1965 +/- ##
==========================================
+ Coverage 90.99% 91.05% +0.06%
==========================================
Files 181 181
Lines 3475 3521 +46
Branches 580 587 +7
==========================================
+ Hits 3162 3206 +44
+ Misses 165 164 -1
- Partials 148 151 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
@al-mart I fixed things up for you, thanks again for the PR |
No description provided.