fix(eslint-plugin-template): prevent the slot tag from being self-closing #2088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sing The slot tag is not included in the tags exposed by the aria-query library, which is used to extract native DOM elements and determine which tags can be self-closing. This fix adds the slot tag and a few other missing tags fix angular-eslint#2087
JamesHenry
requested changes
Nov 18, 2024
packages/eslint-plugin-template/tests/rules/prefer-self-closing-tags/cases.ts
Outdated
Show resolved
Hide resolved
…-closing-tags/cases.ts
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 2b8b2cb. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 5 targetsSent with 💌 from NxCloud. |
JamesHenry
reviewed
Nov 18, 2024
packages/eslint-plugin-template/tests/rules/prefer-self-closing-tags/cases.ts
Show resolved
Hide resolved
JamesHenry
approved these changes
Dec 5, 2024
JamesHenry
requested changes
Dec 5, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2088 +/- ##
=======================================
Coverage 90.73% 90.74%
=======================================
Files 177 177
Lines 3509 3510 +1
Branches 592 592
=======================================
+ Hits 3184 3185 +1
Misses 171 171
Partials 154 154
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The slot tag is not included in the tags exposed by the aria-query library, which is used to extract native DOM elements and determine which tags can be self-closing. This fix adds the slot tag and a few other missing tags
Fixes #2087