Skip to content

feat(eslint-plugin)!: remove deprecated prefer-standalone-component rule #2112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

JamesHenry
Copy link
Member

@angular-eslint/prefer-standalone has been the replacement for some time and is broader than just components

@JamesHenry JamesHenry added the BREAKING CHANGE This is a breaking change and should only be released as part of a new major version label Nov 19, 2024
Copy link

nx-cloud bot commented Nov 19, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0563c01. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 7 targets

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.98%. Comparing base (624970e) to head (0563c01).
Report is 1 commits behind head on next-major-release/v19.

Additional details and impacted files
@@                    Coverage Diff                     @@
##           next-major-release/v19    #2112      +/-   ##
==========================================================
- Coverage                   90.99%   90.98%   -0.01%     
==========================================================
  Files                         181      179       -2     
  Lines                        3475     3449      -26     
  Branches                      580      576       -4     
==========================================================
- Hits                         3162     3138      -24     
+ Misses                        165      164       -1     
+ Partials                      148      147       -1     
Flag Coverage Δ
unittest 90.98% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/eslint-plugin/src/index.ts 72.13% <ø> (-0.45%) ⬇️
---- 🚨 Try these New Features:

@JamesHenry JamesHenry marked this pull request as ready for review November 19, 2024 11:04
@JamesHenry JamesHenry merged commit bece2d9 into next-major-release/v19 Nov 19, 2024
8 checks passed
@JamesHenry JamesHenry deleted the remove-prefer-standalone-component branch November 19, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING CHANGE This is a breaking change and should only be released as part of a new major version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant