feat(eslint-plugin)!: remove deprecated no-host-metadata-property rule #2113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 9f89acf. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 7 targetsSent with 💌 from NxCloud. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next-major-release/v19 #2113 +/- ##
==========================================================
- Coverage 90.98% 90.80% -0.18%
==========================================================
Files 179 177 -2
Lines 3449 3425 -24
Branches 576 572 -4
==========================================================
- Hits 3138 3110 -28
- Misses 164 166 +2
- Partials 147 149 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
JamesHenry
approved these changes
Nov 20, 2024
|
Sorry conflicts with your other one |
ce08514 to
9f89acf
Compare
|
@JamesHenry conflict resolved |
b221dcf
into
angular-eslint:next-major-release/v19
6 checks passed
JamesHenry
pushed a commit
that referenced
this pull request
Nov 23, 2024
#2113) Co-authored-by: Daniel Kimmich <json-derulo@users.noreply.github.com>
JamesHenry
pushed a commit
that referenced
this pull request
Nov 23, 2024
#2113) Co-authored-by: Daniel Kimmich <json-derulo@users.noreply.github.com>
JamesHenry
pushed a commit
that referenced
this pull request
Nov 29, 2024
#2113) Co-authored-by: Daniel Kimmich <json-derulo@users.noreply.github.com>
JamesHenry
pushed a commit
that referenced
this pull request
Nov 29, 2024
#2113) Co-authored-by: Daniel Kimmich <json-derulo@users.noreply.github.com>
pawelfras
added a commit
to SAP/spartacus
that referenced
this pull request
Dec 12, 2024
- ran `npx nx migrate latest` (bump most of libraries to the latest version) and `npx nx migrate --run-migration` (run packages' migration, all except angular's migration from initializer tokens to helper functions) - bump '@angular/animations' to version '^19.0.3' - bump '@angular/common' to version '^19.0.3' - bump '@angular/compiler' to version '^19.0.3' - bump '@angular/core' to version '^19.0.3' - bump '@angular/forms' to version '^19.0.3' - bump '@angular/platform-browser' to version '^19.0.3' - bump '@angular/platform-browser-dynamic' to version '^19.0.3' - bump '@angular/platform-server' to version '^19.0.3' - bump '@angular/pwa' to version '^19.0.4' - bump '@angular/router' to version '^19.0.3' - bump '@angular/service-worker' to version '^19.0.3' - bump '@angular/ssr' to version '^19.0.4' - bump '@ng-select/ng-select' to version '^14.1.0' - bump 'angular-oauth2-oidc' to version '19.0.0' - bump 'ngx-infinite-scroll' to version '^19.0.0' - bump 'zone.js' to version '0.15.0' - bump '@angular-devkit/build-angular' to version '^19.0.4' - bump '@angular-devkit/core' to version '^19.0.4' - bump '@angular-devkit/schematics' to version '^19.0.4' - bump '@angular-eslint/builder' to version '19.0.2' - bump '@angular-eslint/eslint-plugin' to version '^19.0.2' - bump '@angular-eslint/eslint-plugin-template' to version '^19.0.2' - bump '@angular-eslint/schematics' to version '^19.0.2' - bump '@angular-eslint/template-parser' to version '^19.0.2' - bump '@angular-eslint/test-utils' to version '^19.0.2' - bump '@angular-eslint/utils' to version '^19.0.2' - bump '@angular/cli' to version '^19.0.4' - bump '@angular/compiler-cli' to version '^19.0.3' - bump '@angular/language-service' to version '^19.0.3' - bump '@nx/angular' to version '^20.2.2' - bump '@nx/devkit' to version '^20.2.2' - bump '@nx/eslint-plugin' to version '^20.2.2' - bump '@nx/jest' to version '^20.2.2' - bump '@nx/workspace' to version '^20.2.2' - bump '@schematics/angular' to version '^19.0.4' - bump 'jest-preset-angular' to version '14.4.2' - bump 'ng-packagr' to version '^19.0.1' - bump 'nx' to version '^20.2.2' - bump 'typescript' to version '^5.6.3' - add `standalone: false` to all components, directives and pipes for more, see: angular/angular#57643 - add rule `"@angular-eslint/prefer-standalone": "off"` in eslint files - remove deprecated `"angular-eslint/no-host-metadata-property"` for more, see: angular-eslint/angular-eslint#2113
46 tasks
pawelfras
added a commit
to SAP/spartacus
that referenced
this pull request
Dec 12, 2024
- ran `npx nx migrate latest` (bump most of libraries to the latest version) and `npx nx migrate --run-migration` (run packages' migration, all except angular's migration from initializer tokens to helper functions) - bump '@angular/animations' to version '^19.0.3' - bump '@angular/common' to version '^19.0.3' - bump '@angular/compiler' to version '^19.0.3' - bump '@angular/core' to version '^19.0.3' - bump '@angular/forms' to version '^19.0.3' - bump '@angular/platform-browser' to version '^19.0.3' - bump '@angular/platform-browser-dynamic' to version '^19.0.3' - bump '@angular/platform-server' to version '^19.0.3' - bump '@angular/pwa' to version '^19.0.4' - bump '@angular/router' to version '^19.0.3' - bump '@angular/service-worker' to version '^19.0.3' - bump '@angular/ssr' to version '^19.0.4' - bump '@ng-select/ng-select' to version '^14.1.0' - bump 'angular-oauth2-oidc' to version '19.0.0' - bump 'ngx-infinite-scroll' to version '^19.0.0' - bump 'zone.js' to version '0.15.0' - bump '@angular-devkit/build-angular' to version '^19.0.4' - bump '@angular-devkit/core' to version '^19.0.4' - bump '@angular-devkit/schematics' to version '^19.0.4' - bump '@angular-eslint/builder' to version '19.0.2' - bump '@angular-eslint/eslint-plugin' to version '^19.0.2' - bump '@angular-eslint/eslint-plugin-template' to version '^19.0.2' - bump '@angular-eslint/schematics' to version '^19.0.2' - bump '@angular-eslint/template-parser' to version '^19.0.2' - bump '@angular-eslint/test-utils' to version '^19.0.2' - bump '@angular-eslint/utils' to version '^19.0.2' - bump '@angular/cli' to version '^19.0.4' - bump '@angular/compiler-cli' to version '^19.0.3' - bump '@angular/language-service' to version '^19.0.3' - bump '@nx/angular' to version '^20.2.2' - bump '@nx/devkit' to version '^20.2.2' - bump '@nx/eslint-plugin' to version '^20.2.2' - bump '@nx/jest' to version '^20.2.2' - bump '@nx/workspace' to version '^20.2.2' - bump '@schematics/angular' to version '^19.0.4' - bump 'jest-preset-angular' to version '14.4.2' - bump 'ng-packagr' to version '^19.0.1' - bump 'nx' to version '^20.2.2' - bump 'typescript' to version '^5.6.3' - add `standalone: false` to all components, directives and pipes for more, see: angular/angular#57643 - add rule `"@angular-eslint/prefer-standalone": "off"` in eslint files - remove deprecated `"angular-eslint/no-host-metadata-property"` for more, see: angular-eslint/angular-eslint#2113 - update '@angular/ssr' import paths to use the new '/node' entry point when 'CommonEngine' is detected for more, see: angular/angular-cli#28278
pawelfras
added a commit
to SAP/spartacus
that referenced
this pull request
Dec 17, 2024
- move `@angular-eslint/prefer-standalone` to global eslint rules - add missing `OnDestroy` implementation in cds library - remove `@angular-eslint/no-host-metadata-property` from the config as it is no longer part of the package for more, see: angular-eslint/angular-eslint#2113
pawelfras
added a commit
to SAP/spartacus
that referenced
this pull request
Jan 23, 2025
Nx migration: - bump '@angular/**' packages to version '^19.0.3' - bump '@ng-select/ng-select' to version '^14.1.0' - bump 'angular-oauth2-oidc' to version '19.0.0' - bump 'ngx-infinite-scroll' to version '^19.0.0' - bump 'zone.js' to version '0.15.0' - bump '@angular-devkit/**' libraries to version '^19.0.4' - bump '@angular-eslint/**' libraries to version '19.0.2' - bump '@nx/**' libraries to version '^20.2.2' - bump '@schematics/angular' to version '^19.0.4' - bump 'jest-preset-angular' to version '14.4.2' - bump 'ng-packagr' to version '^19.0.1' - bump 'nx' to version '^20.2.2' - bump '@ngrx/**' libraries to version '^19.0.0' - bump 'typescript' to version '^5.6.3' - bump '@typescript-eslint' to '8.18.1' - bump '@angular-builders/custom-webpack' to version '19.0.0' - add standalone: false to all components, directives and pipes for more, see: angular/angular#57643 - add rule "@angular-eslint/prefer-standalone": "off" in eslint files - remove deprecated "angular-eslint/no-host-metadata-property" for more, see: angular-eslint/angular-eslint#2113 - update '@angular/ssr' import paths to use the new '/node' entry point when 'CommonEngine' is detected for more, see: angular/angular-cli#28278 Unit tests issues: - update snapshots - adjust ssr/engine tests to use new required standalone: false property - adjust Jest config for setup/ssr library to use beasties from node_modules instead of the internalized one provided with @angular/ssr due to issues with not supported ES format for more, see: angular/angular-cli#28228 and: angular/angular-cli#28726 Schematics: - refactor `server.ts` to use `dist/server/index.server.html` and adjust schematics - #19878 Migration docs - migration to Angular v19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the deprecated
no-host-metadata-propertyrule, as Angular now recommends using it.