feat(eslint-plugin)!: remove deprecated sort-ngmodule-metadata-arrays rule #2114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit a258271. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 7 targetsSent with 💌 from NxCloud. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next-major-release/v19 #2114 +/- ##
==========================================================
- Coverage 90.98% 90.80% -0.18%
==========================================================
Files 179 177 -2
Lines 3449 3425 -24
Branches 576 574 -2
==========================================================
- Hits 3138 3110 -28
- Misses 164 166 +2
- Partials 147 149 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
JamesHenry
approved these changes
Nov 20, 2024
7d7534a
into
angular-eslint:next-major-release/v19
8 checks passed
JamesHenry
pushed a commit
that referenced
this pull request
Nov 23, 2024
… rule (#2114) Co-authored-by: Daniel Kimmich <json-derulo@users.noreply.github.com>
JamesHenry
pushed a commit
that referenced
this pull request
Nov 23, 2024
… rule (#2114) Co-authored-by: Daniel Kimmich <json-derulo@users.noreply.github.com>
JamesHenry
pushed a commit
that referenced
this pull request
Nov 29, 2024
… rule (#2114) Co-authored-by: Daniel Kimmich <json-derulo@users.noreply.github.com>
JamesHenry
pushed a commit
that referenced
this pull request
Nov 29, 2024
… rule (#2114) Co-authored-by: Daniel Kimmich <json-derulo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the deprecated
sort-ngmodule-metadata-arraysrule, as it is unreliable. Also it does not work in standalone, which is the new default in v19.