-
-
Notifications
You must be signed in to change notification settings - Fork 243
fix(eslint-plugin): adding prefer-signals rule to exported config #2150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(eslint-plugin): adding prefer-signals rule to exported config #2150
Conversation
This needs to be merged asap. The new rule is useless if you can't use it. |
This shouldn't have been possible... There must be an issue with the config generation, I will look into that first |
Ah the validation was there that an exported rule would always end up in the all config (you missed the |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit a5ffb07. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 7 targetsSent with 💌 from NxCloud. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2150 +/- ##
=======================================
Coverage 90.73% 90.73%
=======================================
Files 177 177
Lines 3508 3509 +1
Branches 592 592
=======================================
+ Hits 3183 3184 +1
Misses 171 171
Partials 154 154
Flags with carried forward coverage won't be shown. Click here to find out more.
|
closes #2149