Skip to content

fix(eslint-plugin): adding prefer-signals rule to exported config #2150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 4, 2024

Conversation

quentinderoubaix
Copy link
Contributor

closes #2149

@Frotty
Copy link

Frotty commented Dec 4, 2024

This needs to be merged asap. The new rule is useless if you can't use it.

@JamesHenry
Copy link
Member

This shouldn't have been possible... There must be an issue with the config generation, I will look into that first

@JamesHenry
Copy link
Member

Ah the validation was there that an exported rule would always end up in the all config (you missed the ts-all.ts reference here FYI which the tooling caught) but there was nothing in place to ensure that a rule was exported in the first place, I have pushed that up now

Copy link

nx-cloud bot commented Dec 4, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit a5ffb07. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 7 targets

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.73%. Comparing base (af53867) to head (a5ffb07).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2150   +/-   ##
=======================================
  Coverage   90.73%   90.73%           
=======================================
  Files         177      177           
  Lines        3508     3509    +1     
  Branches      592      592           
=======================================
+ Hits         3183     3184    +1     
  Misses        171      171           
  Partials      154      154           
Flag Coverage Δ
unittest 90.73% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/eslint-plugin/src/index.ts 71.66% <ø> (+0.48%) ⬆️
packages/eslint-plugin/src/rules/prefer-signals.ts 91.11% <ø> (ø)

@JamesHenry JamesHenry merged commit 1cd600d into angular-eslint:main Dec 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[prefer-signals] rule is not exported
3 participants