Skip to content

fix(eslint-plugin): [prefer-standalone] error range should only include property and value #2172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

JamesHenry
Copy link
Member

No description provided.

Copy link

nx-cloud bot commented Dec 10, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 42d6769. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 7 targets

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.78%. Comparing base (5f7ee76) to head (42d6769).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2172      +/-   ##
==========================================
+ Coverage   90.74%   90.78%   +0.04%     
==========================================
  Files         177      177              
  Lines        3510     3507       -3     
  Branches      592      590       -2     
==========================================
- Hits         3185     3184       -1     
+ Misses        171      170       -1     
+ Partials      154      153       -1     
Flag Coverage Δ
unittest 90.78% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...kages/eslint-plugin/src/rules/prefer-standalone.ts 90.00% <ø> (+7.39%) ⬆️
...lint-plugin/tests/rules/prefer-standalone/cases.ts 100.00% <ø> (ø)

@JamesHenry JamesHenry marked this pull request as ready for review December 10, 2024 07:58
@JamesHenry JamesHenry merged commit 7087aee into main Dec 10, 2024
8 checks passed
@JamesHenry JamesHenry deleted the standalone-error-range branch December 10, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant