feat(eslint-plugin-template): [i18n] add additional default ignores #2201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, the documentation links for the i18n docs on angular.dev are wrong. Easiest for me is to just correct that in the PR. However if you prefer separate requests then I will try to find time to do that. |
|
Also, I couldn't find developer setup documentation, nor contributing documentation. So I ran the |
|
All I care about is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #997
Found some issue with the current issue request:
displayModeis an@Inputformat-accordionin Angular Material 19 any longer.mat-drawercan just have text content. https://material.angular.io/components/sidenav/examples#sidenav-backdropmat-iconcan havearia-labels. https://material.angular.io/components/icon/examples#icon-overviewng-containeris specifically recommended by Angular documentation for i18n. https://angular.dev/guide/i18n/prepare#translate-inline-text-without-html-elementtitleis used in SVG and can be translated using i18n.:svg:polygonI am unaware of what is special about the<polygon>element that needs to be ignored.