Skip to content

fix(eslint-plugin): [prefer-signals] support linkedSignal #2213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 24, 2025
Merged

fix(eslint-plugin): [prefer-signals] support linkedSignal #2213

merged 2 commits into from
Jan 24, 2025

Conversation

cexbrayat
Copy link
Contributor

linkedSignal has been introduced in Angular v19, and it should be checked for readonly as the other signals.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jan 23, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit e0f7bc3.

Command Status Duration Result
nx run-many -t e2e-suite --parallel 1 ✅ Succeeded 1m 36s View ↗
nx run-many -t test --codeCoverage ✅ Succeeded 2m 42s View ↗
nx run-many -t build,typecheck,check-rule-docs,... ✅ Succeeded 1m 25s View ↗
nx-cloud record -- pnpm nx sync:check ✅ Succeeded 4s View ↗
nx-cloud record -- pnpm format-check ✅ Succeeded 5s View ↗
nx run-many -t test ✅ Succeeded 32s View ↗
nx run-many -t build ✅ Succeeded 18s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-24 11:39:28 UTC

@cexbrayat cexbrayat force-pushed the fix/prefer-signals-linked-signal branch from 7b8b30e to 216b3e2 Compare January 23, 2025 09:08
@JamesHenry JamesHenry enabled auto-merge (squash) January 23, 2025 11:09
@JamesHenry JamesHenry disabled auto-merge January 23, 2025 15:59
JamesHenry

This comment was marked as duplicate.

Sign in to view

JamesHenry
JamesHenry requested changes Jan 23, 2025
View reviewed changes
Copy link
Member

@JamesHenry JamesHenry left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are broken, you're using symbols without importing them

@cexbrayat
Copy link
Contributor Author

Hi @JamesHenry
The CI was fine before merging the main branch, I suppose another merged PR messed it up.
I'll properly rebase and fix, let me take a look.

@cexbrayat
fix(eslint-plugin): [prefer-signals] support linkedSignal
243568d 
`linkedSignal` has been introduced in Angular v19,
and it should be checked for `readonly` as the other signals.
@cexbrayat cexbrayat force-pushed the fix/prefer-signals-linked-signal branch from 4f2018e to 243568d Compare January 23, 2025 16:12
@cexbrayat
Copy link
Contributor Author

It looks like what was a suggestion is now an autofix. PR should be OK now (tests are green), but the CI failed. Let me know if I need to do something else.

@cexbrayat cexbrayat requested a review from JamesHenry January 24, 2025 08:25
@codecov Codecov
Copy link

codecov bot commented Jan 24, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.44%. Comparing base (45747cd) to head (e0f7bc3).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2213   +/-   ##
=======================================
  Coverage   90.44%   90.44%           
=======================================
  Files         177      177           
  Lines        3527     3527           
  Branches      593      593           
=======================================
  Hits         3190     3190           
  Misses        183      183           
  Partials      154      154
Flag Coverage Δ
unittest 90.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/eslint-plugin/src/rules/prefer-signals.ts 91.11% <ø> (ø)
.../eslint-plugin/tests/rules/prefer-signals/cases.ts 100.00% <ø> (ø)

@JamesHenry JamesHenry merged commit 3475d1c into angular-eslint:main Jan 24, 2025
8 checks passed
@JamesHenry
Copy link
Member

Thanks @cexbrayat!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesHenry JamesHenry Awaiting requested review from JamesHenry

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cexbrayat @JamesHenry