Skip to content

feat(eslint-plugin): prefer-signals now checks .asReadonly() calls #2218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 8, 2025
Merged

feat(eslint-plugin): prefer-signals now checks .asReadonly() calls #2218

merged 2 commits into from
Feb 8, 2025

Conversation

reduckted
Copy link
Contributor

Fixes #2216

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jan 25, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit f831e0f.

Command Status Duration Result
nx run-many -t e2e-suite --parallel 1 ✅ Succeeded 30s View ↗
nx run-many -t test --codeCoverage ✅ Succeeded 1m 20s View ↗
nx run-many -t build,typecheck,check-rule-docs,... ✅ Succeeded 44s View ↗
nx-cloud record -- pnpm nx sync:check ✅ Succeeded 4s View ↗
nx-cloud record -- pnpm format-check ✅ Succeeded 5s View ↗
nx run-many -t test ✅ Succeeded 29s View ↗
nx run-many -t build ✅ Succeeded 18s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-25 06:27:55 UTC

@reduckted reduckted mentioned this pull request Jan 25, 2025
Closed
2 tasks
@codecov Codecov
Copy link

codecov bot commented Jan 25, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.46%. Comparing base (3475d1c) to head (f831e0f).
Report is 5 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2218      +/-   ##
==========================================
+ Coverage   90.44%   90.46%   +0.01%     
==========================================
  Files         177      177              
  Lines        3527     3533       +6     
  Branches      593      596       +3     
==========================================
+ Hits         3190     3196       +6     
  Misses        183      183              
  Partials      154      154
Flag Coverage Δ
unittest 90.46% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/eslint-plugin/src/rules/prefer-signals.ts 92.15% <100.00%> (+1.04%) ⬆️
.../eslint-plugin/tests/rules/prefer-signals/cases.ts 100.00% <ø> (ø)

@JamesHenry JamesHenry merged commit 3690109 into angular-eslint:main Feb 8, 2025
8 checks passed
@reduckted reduckted deleted the feature/prefer-signals-check-asreadonly branch February 8, 2025 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesHenry JamesHenry JamesHenry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[@angular-eslint/prefer-signals] readonly check not working for asReadonly signals
2 participants
@reduckted @JamesHenry