fix(eslint-plugin-template): [prefer-self-closing-tags] do not remove HTML-encoded whitespace #2229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… HTML-encoded whitespace
|
View your CI Pipeline Execution ↗ for commit 77a6357.
☁️ Nx Cloud last updated this comment at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2229 +/- ##
==========================================
+ Coverage 90.44% 90.45% +0.01%
==========================================
Files 177 177
Lines 3527 3532 +5
Branches 593 595 +2
==========================================
+ Hits 3190 3195 +5
Misses 183 183
Partials 154 154
Flags with carried forward coverage won't be shown. Click here to find out more.
|
2 tasks
JamesHenry
approved these changes
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1700
Fixes #1715
The bug was caused by the fact that the template parser decodes HTML entities. For example if the text content of a node is " ", then that is parsed to a
TmplAstTextobject with a value of " ". Likewise,	is parsed to "\t", and so on.So rather than checking if the
TmplAstText.valueproperty is whitespace, we need to get the corresponding text from the source code and see if that text is whitespace.