fix(eslint-plugin-template): [prefer-static-string-properties] do not check structural directives #2253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… check structural directives
|
View your CI Pipeline Execution ↗ for commit 2205adc.
☁️ Nx Cloud last updated this comment at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2253 +/- ##
=======================================
Coverage 90.53% 90.53%
=======================================
Files 179 179
Lines 3559 3559
Branches 600 600
=======================================
Hits 3222 3222
Misses 183 183
Partials 154 154
Flags with carried forward coverage won't be shown. Click here to find out more.
|
JamesHenry
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2237
A simple fix. The rule should only check
BoundAttributenodes that are in theinputscollection of an element, and not in thetemplateAttrscollection.