Skip to content

feat(template-parser)!: do not suppress parse errors by default #2255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 24, 2025
Merged

feat(template-parser)!: do not suppress parse errors by default #2255

merged 2 commits into from
May 24, 2025

Conversation

reduckted
Copy link
Contributor

@reduckted reduckted commented Feb 22, 2025 •
edited
Loading

Fixes #1641

🚨 Breaking change 🚨

Template parse errors will now result in an error from ESLint.

Note: This is currently blocked by #2256.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Feb 22, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 9e1b757.

Command Status Duration Result
nx run-many -t e2e-suite --parallel 1 ✅ Succeeded 39s View ↗
nx run-many -t test --codeCoverage ✅ Succeeded 1m 16s View ↗
nx run-many -t build,typecheck,check-rule-docs,... ✅ Succeeded 49s View ↗
nx-cloud record -- pnpm nx sync:check ✅ Succeeded 4s View ↗
nx-cloud record -- pnpm format-check ✅ Succeeded 6s View ↗
nx run-many -t test ✅ Succeeded 42s View ↗
nx run-many -t build ✅ Succeeded 17s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-22 13:39:49 UTC

reduckted
reduckted commented Feb 22, 2025
View reviewed changes
@codecov Codecov
Copy link

codecov bot commented Feb 26, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.10%. Comparing base (5d83916) to head (9e1b757).
Report is 90 commits behind head on next-major-release/v20.

Additional details and impacted files 
@@                    Coverage Diff                     @@
##           next-major-release/v20    #2255      +/-   ##
==========================================================
- Coverage                   92.53%   92.10%   -0.44%     
==========================================================
  Files                         184      184              
  Lines                        3726     3725       -1     
  Branches                      836      835       -1     
==========================================================
- Hits                         3448     3431      -17     
- Misses                        215      231      +16     
  Partials                       63       63
Flag Coverage Δ
unittest 92.10% <100.00%> (-0.44%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...eslint-plugin-template/tests/rules/eqeqeq/cases.ts 100.00% <ø> (ø)
...s/eslint-plugin-template/tests/rules/i18n/cases.ts 100.00% <ø> (ø)
...n-template/tests/rules/no-call-expression/cases.ts 100.00% <ø> (ø)
...-plugin-template/tests/rules/prefer-ngsrc/cases.ts 100.00% <ø> (ø)
packages/template-parser/src/index.ts 90.52% <100.00%> (-0.10%) ⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JamesHenry JamesHenry added the BREAKING CHANGE This is a breaking change and should only be released as part of a new major version label Mar 2, 2025
@JamesHenry JamesHenry added this to the v20 milestone Mar 2, 2025
@JamesHenry JamesHenry changed the base branch from main to next-major-release/v20 May 24, 2025 21:01
@JamesHenry JamesHenry merged commit 2eb1e9d into angular-eslint:next-major-release/v20 May 24, 2025
8 checks passed
@JamesHenry
Copy link
Member

Thanks again for this, finally time to get it into the v20 branch!

@JamesHenry JamesHenry mentioned this pull request May 24, 2025
Merged
10 tasks
@reduckted reduckted deleted the bugfix/1641 branch May 24, 2025 22:36
JamesHenry pushed a commit that referenced this pull request May 26, 2025
@reduckted @JamesHenry
feat(template-parser)!: do not suppress parse errors by default (#2255)
60c6c6c
JamesHenry pushed a commit that referenced this pull request May 26, 2025
@reduckted @JamesHenry
feat(template-parser)!: do not suppress parse errors by default (#2255)
88f95bd
JamesHenry pushed a commit that referenced this pull request May 26, 2025
@reduckted @JamesHenry
feat(template-parser)!: do not suppress parse errors by default (#2255)
eec9148
JamesHenry pushed a commit that referenced this pull request May 27, 2025
@reduckted @JamesHenry
feat(template-parser)!: do not suppress parse errors by default (#2255)
86de0b2
JamesHenry pushed a commit that referenced this pull request May 28, 2025
@reduckted @JamesHenry
feat(template-parser)!: do not suppress parse errors by default (#2255)
d26776a
JamesHenry pushed a commit that referenced this pull request May 28, 2025
@reduckted @JamesHenry
feat(template-parser)!: do not suppress parse errors by default (#2255)
c2239f7
JamesHenry pushed a commit that referenced this pull request May 31, 2025
@reduckted @JamesHenry
feat(template-parser)!: do not suppress parse errors by default (#2255)
68bce9d
JamesHenry pushed a commit that referenced this pull request Jun 1, 2025
@reduckted @JamesHenry
feat(template-parser)!: do not suppress parse errors by default (#2255)
a2d4334
JamesHenry pushed a commit that referenced this pull request Jun 2, 2025
@reduckted @JamesHenry
feat(template-parser)!: do not suppress parse errors by default (#2255)
6717a1f
JamesHenry pushed a commit that referenced this pull request Jun 6, 2025
@reduckted @JamesHenry
feat(template-parser)!: do not suppress parse errors by default (#2255)
2c37680
JamesHenry pushed a commit that referenced this pull request Jun 6, 2025
@reduckted @JamesHenry
feat(template-parser)!: do not suppress parse errors by default (#2255)
6c77dd9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
BREAKING CHANGE This is a breaking change and should only be released as part of a new major version
Projects
None yet
Milestone
v20
Development

Successfully merging this pull request may close these issues.

[prefer-self-closing-tags] Conflicts with new control flow and custom selectors
2 participants
@reduckted @JamesHenry