feat(eslint-plugin): add rule require-lifecycle-on-prototype #2259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit 1f2bf7e.
☁️ Nx Cloud last updated this comment at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2259 +/- ##
==========================================
+ Coverage 90.53% 90.61% +0.08%
==========================================
Files 179 181 +2
Lines 3559 3591 +32
Branches 600 605 +5
==========================================
+ Hits 3222 3254 +32
Misses 183 183
Partials 154 154
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1002
This rule ensures that lifecycle methods are defined against the object's prototype instead of the object's instance.
Rather than limiting this rule to only check within component, directive, pipe and service (injectable) classes, the rule checks assignments everywhere. I think this is better because it will also catch cases where helper functions are used to incorrectly add lifecycle methods. For example, it will catch the problem with this code: