Skip to content

fix(prefer-static-string-properties): resolve bug with directives #2271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 28, 2025
Merged

fix(prefer-static-string-properties): resolve bug with directives #2271

merged 2 commits into from
Feb 28, 2025

Conversation

mbriand-lucca
Copy link
Contributor

We don't want to use this rule for directives like *ngSwitchCase or *ngIf

fixes #2265

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Feb 27, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 46ee007.

Command Status Duration Result
nx run-many -t e2e-suite --parallel 1 ✅ Succeeded 15s View ↗
nx run-many -t test --codeCoverage ✅ Succeeded 1m 38s View ↗
nx run-many -t build,typecheck,check-rule-docs,... ✅ Succeeded 1m 17s View ↗
nx-cloud record -- pnpm nx sync:check ✅ Succeeded 4s View ↗
nx-cloud record -- pnpm format-check ✅ Succeeded 5s View ↗
nx run-many -t test ✅ Succeeded 23s View ↗
nx run-many -t build ✅ Succeeded 11s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-27 15:50:11 UTC

@mbriand-lucca
Copy link
Contributor Author

I'm not sure if the code is great, feel free to let me know if there’s anything to improve :)

@codecov Codecov
Copy link

codecov bot commented Feb 27, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.26%. Comparing base (13834c4) to head (46ee007).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2271   +/-   ##
=======================================
  Coverage   92.25%   92.26%           
=======================================
  Files         179      179           
  Lines        3333     3334    +1     
  Branches      678      678           
=======================================
+ Hits         3075     3076    +1     
  Misses        200      200           
  Partials       58       58
Flag Coverage Δ
unittest 92.26% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...plate/src/rules/prefer-static-string-properties.ts 100.00% <100.00%> (ø)
...sts/rules/prefer-static-string-properties/cases.ts 100.00% <ø> (ø)

JamesHenry
JamesHenry approved these changes Feb 28, 2025
View reviewed changes
Copy link
Member

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@JamesHenry JamesHenry merged commit c6d6457 into angular-eslint:main Feb 28, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesHenry JamesHenry JamesHenry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[@angular-eslint/template/prefer-static-string-properties] The rule replaces where it is not needed
2 participants
@mbriand-lucca @JamesHenry