Skip to content

fix(eslint-plugin-template): [prefer-self-closing-tags] resolve wrong reports when structural directive + no content + no self-closing #2287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 8, 2025
Merged

fix(eslint-plugin-template): [prefer-self-closing-tags] resolve wrong reports when structural directive + no content + no self-closing #2287

merged 2 commits into from
Mar 8, 2025

Conversation

g-drouard
Copy link
Contributor

Fixes #2280

Regression from #2256

@g-drouard g-drouard mentioned this pull request Mar 5, 2025
Closed
@g-drouard g-drouard changed the title fix(eslint-plugin-template): [prefer-self-closing-tags] resolve wrong reports with structural directive + no content + no closing tag fix(eslint-plugin-template): [prefer-self-closing-tags] resolve wrong reports with structural directive + no content + no self-closing Mar 5, 2025
@g-drouard g-drouard force-pushed the fix-2280 branch 2 times, most recently from 329ccc4 to c9c8682 Compare March 5, 2025 20:14
@g-drouard g-drouard changed the title fix(eslint-plugin-template): [prefer-self-closing-tags] resolve wrong reports with structural directive + no content + no self-closing fix(eslint-plugin-template): [prefer-self-closing-tags] resolve wrong reports when structural directive + no content + no self-closing Mar 6, 2025
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Mar 8, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit d3594a2.

Command Status Duration Result
nx run-many -t e2e-suite --parallel 1 ✅ Succeeded 26s View ↗
nx run-many -t test --codeCoverage ✅ Succeeded 59s View ↗
nx run-many -t build,typecheck,check-rule-docs,... ✅ Succeeded 37s View ↗
nx-cloud record -- pnpm nx sync:check ✅ Succeeded 3s View ↗
nx-cloud record -- pnpm format-check ✅ Succeeded 5s View ↗
nx run-many -t test ✅ Succeeded 27s View ↗
nx run-many -t build ✅ Succeeded 13s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-08 15:41:06 UTC

@JamesHenry
Copy link
Member

JamesHenry commented Mar 8, 2025 •
edited
Loading

Thanks a lot for this @g-drouard, whenever you update unit tests you need to regen the docs with pnpm update-rule-docs. The docs are generated directly from the implementations and tests to allow them to stay evergreen.

JamesHenry
JamesHenry requested changes Mar 8, 2025
View reviewed changes
Copy link
Member

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

@g-drouard g-drouard requested a review from JamesHenry March 8, 2025 15:23
@codecov Codecov
Copy link

codecov bot commented Mar 8, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.33%. Comparing base (fef02ff) to head (d3594a2).
Report is 15 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2287      +/-   ##
==========================================
+ Coverage   92.32%   92.33%   +0.01%     
==========================================
  Files         181      181              
  Lines        3362     3367       +5     
  Branches      684      685       +1     
==========================================
+ Hits         3104     3109       +5     
  Misses        200      200              
  Partials       58       58
Flag Coverage Δ
unittest 92.33% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...gin-template/src/rules/prefer-self-closing-tags.ts 98.14% <100.00%> (+0.18%) ⬆️
...late/tests/rules/prefer-self-closing-tags/cases.ts 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JamesHenry JamesHenry merged commit 3be1559 into angular-eslint:main Mar 8, 2025
7 checks passed
@JamesHenry
Copy link
Member

Thank you @g-drouard!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesHenry JamesHenry JamesHenry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@angular-eslint/template/prefer-self-closing-tags reports on empty <tr>
2 participants
@g-drouard @JamesHenry