Skip to content

feat(template-parser): visit @let child nodes #2312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 22, 2025

Conversation

reduckted
Copy link
Contributor

Added support for @let statements in the template parser.

I originally did this as part of #2311, but I'm making a separate PR for it so that it can be merged in sooner for #2308.

Copy link

nx-cloud bot commented Mar 10, 2025

View your CI Pipeline Execution ↗ for commit 15f8e0d.

Command Status Duration Result
nx run-many -t e2e-suite --parallel 1 ✅ Succeeded 21s View ↗
nx run-many -t test --codeCoverage ✅ Succeeded 1m 19s View ↗
nx run-many -t build,typecheck,check-rule-docs,... ✅ Succeeded 49s View ↗
nx-cloud record -- pnpm nx sync:check ✅ Succeeded 4s View ↗
nx-cloud record -- pnpm format-check ✅ Succeeded 5s View ↗
nx run-many -t test ✅ Succeeded 41s View ↗
nx run-many -t build ✅ Succeeded 15s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-22 06:33:04 UTC

@reduckted
Copy link
Contributor Author

reduckted commented Mar 10, 2025

🤔 Not sure what's going on with the Node v18 build. I can't see any reason for it to fail.

Fixed with a re-run.

@JamesHenry JamesHenry merged commit eb6d4b5 into angular-eslint:main Mar 22, 2025
7 checks passed
@JamesHenry
Copy link
Member

Thank you!

@reduckted reduckted deleted the feature/let-child-nodes branch March 22, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants