fix(eslint-plugin-template): [attributes-order] treat inputs without square brackets as attributes #2316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit 9490faa.
☁️ Nx Cloud last updated this comment at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2316 +/- ##
==========================================
+ Coverage 92.36% 92.39% +0.03%
==========================================
Files 181 181
Lines 3377 3419 +42
Branches 689 704 +15
==========================================
+ Hits 3119 3159 +40
- Misses 200 201 +1
- Partials 58 59 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
Thanks I merged #2307 |
…square brackets as attributes
3addfec to
9490faa
Compare
JamesHenry
approved these changes
Mar 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1914
Given an element with two attributes, where one sets a static valid and the other uses interpolation, Angular classifies the first attribute as an "attribute" and the second attribute as an "input".
See here for an example of the AST (the template parser it uses is quite a few versions behind, but the same behavior exists with v19):
https://astexplorer.net/#/gist/cd84edb20d811a8896c9f28f6f5031d9/1567654ea0ba120f0c3844e9786387bb3c921d17
This pull request changes the
attributes-orderrule such that an input will only be classified as an input if it's surrounded with square brackets.Note
This PR is piggy-backing off #2307 since that PR made large changes to theattributes-orderrule. Once/if that is merged, then I'll rebase this PR to remove the extra commits.The specific commit that is relevant to this PR is 6fc0cd5.