Skip to content

feat: use @angular/compiler 19.2.3 and rename some AST nodes to match #2320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 22, 2025
Merged

feat: use @angular/compiler 19.2.3 and rename some AST nodes to match #2320

merged 1 commit into from
Mar 22, 2025

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 12, 2025 •
edited by JamesHenry
Loading

⚠️ NOTE FOR RULE AUTHORS:

It seems Angular renamed the following AST nodes:

Text$3 -> Text
Element$1 -> Element
Interpolation$1 -> Interpolation
LetDeclaration$1 -> LetDeclaration
Icu$1 -> Icu

Dropping the $number suffix is usually the sign that a node has moved to being considered "stable".

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@angular/compiler (source) 19.2.1 -> 19.2.3 age adoption passing confidence

Release Notes

angular/angular (@​angular/compiler)

v19.2.3

Compare Source

compiler-cli
Commit Type Description
aa8ea7a5b2 fix report more accurate diagnostic for invalid import (#​60455)
core
Commit Type Description
13a8709b2b fix catch hydration marker with implicit body tag (#​60429)
296aded9da fix execute timer trigger outside zone (#​60392)
0615ffb4f7 fix include input name in error message (#​60404)
platform-browser-dynamic
Commit Type Description
1e06c8e8b6 fix ensure compiler is loaded before @angular/common (#​60458)
upgrade
Commit Type Description
9e1a1030c8 fix handle output emitters when downgrading a component (#​60369)

v19.2.2

Compare Source

common
Commit Type Description
90a16a1088 fix support equality function in httpResource (#​60026)
compiler
Commit Type Description
56b551d273 fix incorrect spans for template literals (#​60323) (#​60331)
compiler-cli
Commit Type Description
23ca88522b fix handle transformed classes when generating HMR code (#​60298)
core
Commit Type Description
6dc41265fd fix check whether application is destroyed before initializing event replay (#​59789)
bb12b30d52 fix ensures immediate trigger fires properly with lazy loaded routes (#​60203)
b144dd946e fix fix removal of a container reference used in the component file (#​60210)
platform-server
Commit Type Description
15c42969fc fix add missing peer dependency for rxjs (#​60308)
router
Commit Type Description
7bcdf7c143 fix update symbols (#​60233)

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Mar 12, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit f71a9ea.

Command Status Duration Result
nx run-many -t test ✅ Succeeded 23s View ↗
nx run-many -t build ✅ Succeeded 11s View ↗
nx run-many -t e2e-suite --parallel 1 ✅ Succeeded 10m 31s View ↗
nx run-many -t test --codeCoverage ✅ Succeeded 1m 5s View ↗
nx run-many -t build,typecheck,check-rule-docs,... ✅ Succeeded 44s View ↗
nx-cloud record -- pnpm nx sync:check ✅ Succeeded 4s View ↗
nx-cloud record -- pnpm format-check ✅ Succeeded 5s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-22 10:25:36 UTC

@renovate renovate bot changed the title fix: update dependency @angular/compiler to v19.2.2 fix: update dependency @angular/compiler to v19.2.3 Mar 19, 2025
@renovate renovate bot force-pushed the renovate/angular-monorepo branch 3 times, most recently from 573032d to b871dbc Compare March 22, 2025 08:48
@codecov Codecov
Copy link

codecov bot commented Mar 22, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.39%. Comparing base (3335025) to head (f71a9ea).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
.../template-parser/src/convert-source-span-to-loc.ts 0.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (50.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2320   +/-   ##
=======================================
  Coverage   92.39%   92.39%           
=======================================
  Files         181      181           
  Lines        3419     3419           
  Branches      704      704           
=======================================
  Hits         3159     3159           
  Misses        201      201           
  Partials       59       59
Flag Coverage Δ
unittest 92.39% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...kages/eslint-plugin-template/src/rules/alt-text.ts 92.85% <ø> (ø)
...lint-plugin-template/src/rules/attributes-order.ts 94.67% <ø> (ø)
...slint-plugin-template/src/rules/button-has-type.ts 100.00% <ø> (ø)
...template/src/rules/click-events-have-key-events.ts 100.00% <ø> (ø)
...lugin-template/src/rules/conditional-complexity.ts 100.00% <ø> (ø)
...lint-plugin-template/src/rules/elements-content.ts 94.73% <ø> (ø)
packages/eslint-plugin-template/src/rules/i18n.ts 92.64% <ø> (ø)
...n-template/src/rules/interactive-supports-focus.ts 100.00% <ø> (ø)
...template/src/rules/label-has-associated-control.ts 91.30% <ø> (ø)
...template/src/rules/mouse-events-have-key-events.ts 100.00% <ø> (ø)
... and 13 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JamesHenry JamesHenry force-pushed the renovate/angular-monorepo branch from b871dbc to 77de89b Compare March 22, 2025 09:58
@JamesHenry JamesHenry changed the title fix: update dependency @angular/compiler to v19.2.3 feat: use @angular/compiler 19.2.3 and align Text, Element, Interpolation nodes Mar 22, 2025
@JamesHenry JamesHenry force-pushed the renovate/angular-monorepo branch from 77de89b to 6f90d6e Compare March 22, 2025 10:05
@JamesHenry JamesHenry changed the title feat: use @angular/compiler 19.2.3 and align Text, Element, Interpolation nodes feat: use @angular/compiler 19.2.3 and rename Text, Element, Interpolation nodes Mar 22, 2025
@JamesHenry JamesHenry changed the title feat: use @angular/compiler 19.2.3 and rename Text, Element, Interpolation nodes feat: use @angular/compiler 19.2.3 and rename some AST nodes to match Mar 22, 2025
@renovate Renovate
Copy link
Contributor Author

renovate bot commented Mar 22, 2025

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@JamesHenry JamesHenry force-pushed the renovate/angular-monorepo branch from df0206c to f71a9ea Compare March 22, 2025 10:12
@JamesHenry JamesHenry merged commit 5a04396 into main Mar 22, 2025
10 of 11 checks passed
@JamesHenry JamesHenry deleted the renovate/angular-monorepo branch March 22, 2025 10:26
@JamesHenry
Copy link
Member

FYI @reduckted a bunch of nodes changed but hopefully should be stable now

@LeonEck LeonEck mentioned this pull request Mar 27, 2025
Closed
cpaulve-1A added a commit to AmadeusITGroup/otter that referenced this pull request Mar 31, 2025
@cpaulve-1A
fix: rename AST node to match angular compiler
9b23f6f 
Apply angular-eslint/angular-eslint#2320 on custom plugins
cpaulve-1A added a commit to AmadeusITGroup/otter that referenced this pull request Apr 1, 2025
@cpaulve-1A
fix: rename AST node to match angular compiler
360331e 
Apply angular-eslint/angular-eslint#2320 on custom plugins
cpaulve-1A added a commit to AmadeusITGroup/otter that referenced this pull request Apr 1, 2025
@cpaulve-1A
fix: rename AST node to match angular compiler
a968a7e 
Apply angular-eslint/angular-eslint#2320 on custom plugins
cpaulve-1A added a commit to AmadeusITGroup/otter that referenced this pull request Apr 1, 2025
@cpaulve-1A
fix: rename AST node to match angular compiler
4ffb049 
Apply angular-eslint/angular-eslint#2320 on custom plugins
cpaulve-1A added a commit to AmadeusITGroup/otter that referenced this pull request Apr 1, 2025
@cpaulve-1A
fix: rename AST node to match angular compiler
795738a 
Apply angular-eslint/angular-eslint#2320 on custom plugins
cpaulve-1A added a commit to AmadeusITGroup/otter that referenced this pull request Apr 1, 2025
@cpaulve-1A
fix: rename AST node to match angular compiler
5ee1a20 
Apply angular-eslint/angular-eslint#2320 on custom plugins
kpanot pushed a commit to AmadeusITGroup/otter that referenced this pull request Apr 8, 2025
@cpaulve-1A @kpanot
fix: rename AST node to match angular compiler
f52434d 
Apply angular-eslint/angular-eslint#2320 on custom plugins
@Blackbaud-SteveBrush Blackbaud-SteveBrush mentioned this pull request Apr 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JamesHenry