feat(eslint-plugin-template): [button-has-type] add option to ignore missing type #2326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit fe64ac5.
☁️ Nx Cloud last updated this comment at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2326 +/- ##
==========================================
+ Coverage 92.33% 92.36% +0.02%
==========================================
Files 181 181
Lines 3367 3377 +10
Branches 685 689 +4
==========================================
+ Hits 3109 3119 +10
Misses 200 200
Partials 58 58
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
JamesHenry
approved these changes
Mar 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2193
Adds an
ignoreWithDirectivesoption that specifies the names of directives (or attributes) that, when present on thebuttonelement, will cause thebutton-has-typerule to not report a problem.I went with "ignore" rather than "allow", but I'm happy to change it to something else if needed.
I've still kept the "invalidType" check, so even if the "missingType" check is skipped, if you specify a
typeattribute with an invalid value, the rule will still report a problem.