Skip to content

fix(eslint-plugin-template): [no-any] handle key reads (#1701) #2335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 9, 2025
Merged

fix(eslint-plugin-template): [no-any] handle key reads (#1701) #2335

merged 7 commits into from
Apr 9, 2025

Conversation

undsoft
Copy link
Contributor

@undsoft undsoft commented Mar 22, 2025

Fixes #1701

Now properly handles cases like:

{{ $any(attributeList)['NPSScore'] }}

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Mar 22, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 9be136b.

Command Status Duration Result
nx run-many -t e2e-suite --parallel 1 ✅ Succeeded 34s View ↗
nx run-many -t test --codeCoverage ✅ Succeeded 42s View ↗
nx run-many -t build,typecheck,check-rule-docs,... ✅ Succeeded 47s View ↗
nx-cloud record -- pnpm nx sync:check ✅ Succeeded 4s View ↗
nx-cloud record -- pnpm format-check ✅ Succeeded 5s View ↗
nx run-many -t test ✅ Succeeded 30s View ↗
nx run-many -t build ✅ Succeeded 14s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-28 07:53:57 UTC

@codecov Codecov
Copy link

codecov bot commented Mar 22, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 91.30435% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.56%. Comparing base (0bda61b) to head (9be136b).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...ackages/eslint-plugin-template/src/rules/no-any.ts 91.30% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2335      +/-   ##
==========================================
+ Coverage   92.53%   92.56%   +0.02%     
==========================================
  Files         184      184              
  Lines        3726     3741      +15     
  Branches      836      840       +4     
==========================================
+ Hits         3448     3463      +15     
  Misses        215      215              
  Partials       63       63
Flag Coverage Δ
unittest 92.56% <91.30%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...eslint-plugin-template/tests/rules/no-any/cases.ts 100.00% <ø> (ø)
...ackages/eslint-plugin-template/src/rules/no-any.ts 93.75% <91.30%> (+5.51%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

JamesHenry
JamesHenry approved these changes Apr 9, 2025
View reviewed changes
Copy link
Member

@JamesHenry JamesHenry left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@JamesHenry JamesHenry merged commit ff265d2 into angular-eslint:main Apr 9, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesHenry JamesHenry JamesHenry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[@angular-eslint/template/no-any] does not throw error for property binding with square bracket notation
2 participants
@undsoft @JamesHenry