fix(eslint-plugin-template): correct column adjustment for inline template message locations #2358
+107
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plate message locations
|
View your CI Pipeline Execution ↗ for commit 71fd02b.
☁️ Nx Cloud last updated this comment at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2358 +/- ##
=======================================
Coverage 92.59% 92.59%
=======================================
Files 186 186
Lines 3752 3756 +4
Branches 840 842 +2
=======================================
+ Hits 3474 3478 +4
Misses 215 215
Partials 63 63
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2356
The problem was that the
columnandendColumnwere not being adjusted when transforming the message locations from being within the inline template string to being within the full code file that the inline template was in. Not adjusting the columns is the correct thing to do for anything but the first line, because the second and subsequent lines always start at column 1, while the first line starts wherever the string starts on that line, plus one character for the opening quote.