Skip to content

fix(eslint-plugin-template): [label-has-associated-control] labelComponents should override default label inputs #2360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 2, 2025
Merged

fix(eslint-plugin-template): [label-has-associated-control] labelComponents should override default label inputs #2360

merged 2 commits into from
Jun 2, 2025

Conversation

cprestegard
Copy link
Contributor

Example PR to address #2359

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Apr 17, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 453a046.

Command Status Duration Result
nx run-many -t e2e-suite --parallel 1 ✅ Succeeded 22s View ↗
nx run-many -t test --codeCoverage ✅ Succeeded 1m 15s View ↗
nx run-many -t build,typecheck,check-rule-docs,... ✅ Succeeded 1m 5s View ↗
nx-cloud record -- pnpm nx sync:check ✅ Succeeded 2s View ↗
nx-cloud record -- pnpm format-check ✅ Succeeded 6s View ↗

☁️ Nx Cloud last updated this comment at 2025-06-02 08:13:58 UTC

@JamesHenry
Copy link
Member

@cprestegard Did you notice that CI failed on this one? Looks like you need to fix up the formatting please

JamesHenry
JamesHenry requested changes May 8, 2025
View reviewed changes
Copy link
Member

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

@codecov Codecov
Copy link

codecov bot commented Jun 2, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.90%. Comparing base (ff265d2) to head (453a046).
Report is 117 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2360      +/-   ##
==========================================
+ Coverage   92.59%   92.90%   +0.31%     
==========================================
  Files         186      200      +14     
  Lines        3752     4185     +433     
  Branches      840      977     +137     
==========================================
+ Hits         3474     3888     +414     
- Misses        215      229      +14     
- Partials       63       68       +5
Flag Coverage Δ
unittest 92.90% <100.00%> (+0.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...template/src/rules/label-has-associated-control.ts 93.87% <100.00%> (+2.57%) ⬆️
.../tests/rules/label-has-associated-control/cases.ts 100.00% <ø> (ø)

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JamesHenry JamesHenry changed the title feat(eslint-plugin-template): [label-has-associated-control] allow override of default label inputs fix(eslint-plugin-template): [label-has-associated-control] labelComponents should override default label inputs Jun 2, 2025
@JamesHenry JamesHenry merged commit 4d31352 into angular-eslint:main Jun 2, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesHenry JamesHenry JamesHenry requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cprestegard @JamesHenry