Skip to content

feat(eslint-plugin-template): [no-interpolation-in-attributes] add allowSubstringInterpolation option #2373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 20, 2025
Merged

feat(eslint-plugin-template): [no-interpolation-in-attributes] add allowSubstringInterpolation option #2373

merged 1 commit into from
Apr 20, 2025

Conversation

daiscog
Copy link
Contributor

@daiscog daiscog commented Apr 14, 2025

Closes #2039

JamesHenry
JamesHenry approved these changes Apr 20, 2025
View reviewed changes
Copy link
Member

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @daiscog!

@JamesHenry JamesHenry changed the title feat(eslint-plugin-template): add allowSubstringInterpolation to no-interpolation-in-attributes feat(eslint-plugin-template): [no-interpolation-in-attributes] add allowSubstringInterpolation option Apr 20, 2025
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Apr 20, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit b134b7a.

Command Status Duration Result
nx run-many -t e2e-suite --parallel 1 ✅ Succeeded 49s View ↗
nx run-many -t test --codeCoverage ✅ Succeeded 1m 4s View ↗
nx run-many -t build,typecheck,check-rule-docs,... ✅ Succeeded 56s View ↗
nx-cloud record -- pnpm nx sync:check ✅ Succeeded 4s View ↗
nx-cloud record -- pnpm format-check ✅ Succeeded 5s View ↗
nx run-many -t test ✅ Succeeded 28s View ↗
nx run-many -t build ✅ Succeeded 18s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-20 15:21:55 UTC

@codecov Codecov
Copy link

codecov bot commented Apr 20, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.66%. Comparing base (c69c743) to head (b134b7a).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2373   +/-   ##
=======================================
  Coverage   92.65%   92.66%           
=======================================
  Files         186      186           
  Lines        3756     3761    +5     
  Branches      842      844    +2     
=======================================
+ Hits         3480     3485    +5     
  Misses        213      213           
  Partials       63       63
Flag Coverage Δ
unittest 92.66% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...mplate/src/rules/no-interpolation-in-attributes.ts 100.00% <100.00%> (ø)
...ests/rules/no-interpolation-in-attributes/cases.ts 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JamesHenry JamesHenry merged commit 6efbfad into angular-eslint:main Apr 20, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesHenry JamesHenry JamesHenry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[no-interpolation-in-attributes] add config to allow interpolation for a substring of the attribute value
2 participants
@daiscog @JamesHenry