-
Notifications
You must be signed in to change notification settings - Fork 245
feat(eslint-plugin): add no-uncalled-signals rule #2383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fc8bd24
to
41eaa68
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TypeScript has always referred to this as uncalled function checks: https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-7.html#uncalled-function-checks
So maybe no-uncalled-signals
is a better name (given it doesn't check any other kind of "misuse")?
WDYT about the name @reduckted? |
I think |
6826326
to
74db158
Compare
Thanks for the feedback! I've reverted the |
74db158
to
fd51cce
Compare
View your CI Pipeline Execution ↗ for commit 42d68fd.
☁️ Nx Cloud last updated this comment at |
@scj7t4 Thanks please see the CI failures they tell you what to do to fix them |
f2adafb
to
33e6dfc
Compare
Should be fixed |
@scj7t4 You'll need to run these two commands to update some generated files:
|
Checks that signals used in logical expressions are invoked. For angular-eslint#2302
…logical expression test case
c9d9712
to
42d68fd
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2383 +/- ##
==========================================
+ Coverage 92.88% 92.91% +0.03%
==========================================
Files 197 200 +3
Lines 4145 4165 +20
Branches 970 972 +2
==========================================
+ Hits 3850 3870 +20
Misses 227 227
Partials 68 68
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Thanks so much for this! |
can we use this rule in the template for control flow for example? invalid valid |
@danielvieira1 No, template rules work totally differently in a different plugin, that would require a separate rule |
Checks that signals used in logical expressions are invoked. For #2302
Thanks for your work on the project! This is my first attempt at a typescript eslint plugin, so feedback is very appreciated on what I messed up :)