Skip to content

fix(eslint-plugin-template): [alt-text] ensure multiple attributes do not cause false negatives #2441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

JamesHenry
Copy link
Member

Summary

  • add examples with extra attributes in alt-text rule tests
  • fix alt-text rule to properly accumulate attributes

Testing

  • NX_NO_CLOUD=true pnpm nx test eslint-plugin-template --runInBand

Copy link

nx-cloud bot commented May 24, 2025

View your CI Pipeline Execution ↗ for commit e9abdc3.

Command Status Duration Result
nx run-many -t e2e-suite --parallel 1 ✅ Succeeded 13s View ↗
nx run-many -t test --codeCoverage ✅ Succeeded 50s View ↗
nx run-many -t build,typecheck,check-rule-docs,... ✅ Succeeded 41s View ↗
nx-cloud record -- pnpm nx sync:check ✅ Succeeded 2s View ↗
nx-cloud record -- pnpm format-check ✅ Succeeded 6s View ↗
nx run-many -t test ✅ Succeeded 25s View ↗
nx run-many -t build ✅ Succeeded 13s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-24 13:32:10 UTC

@JamesHenry JamesHenry changed the title Add alt-text attribute coverage fix(eslint-plugin-template): [alt-text] ensure multiple attributes do not cause false negatives May 24, 2025
Copy link

codecov bot commented May 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.83%. Comparing base (dbc01a9) to head (e9abdc3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2441      +/-   ##
==========================================
+ Coverage   92.72%   92.83%   +0.10%     
==========================================
  Files         195      195              
  Lines        4071     4073       +2     
  Branches      937      945       +8     
==========================================
+ Hits         3775     3781       +6     
+ Misses        228      225       -3     
+ Partials       68       67       -1     
Flag Coverage Δ
unittest 92.83% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...kages/eslint-plugin-template/src/rules/alt-text.ts 100.00% <100.00%> (+7.14%) ⬆️
...lint-plugin-template/tests/rules/alt-text/cases.ts 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JamesHenry JamesHenry merged commit 61f631c into main May 24, 2025
8 checks passed
@JamesHenry JamesHenry deleted the codex/add-test-cases-for-alt-text-with-extra-attributes branch May 24, 2025 13:33
igord pushed a commit to tcorral/angular-eslint that referenced this pull request Jun 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant