Skip to content

fix(schematics): ensure @eslint/js and @angular-eslint/builder are always available in non-npm repos #2486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 31, 2025
Merged

fix(schematics): ensure @eslint/js and @angular-eslint/builder are always available in non-npm repos #2486

merged 3 commits into from
May 31, 2025

Conversation

JamesHenry
Copy link
Member

Closes #2241

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented May 31, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit c3c421e.

Command Status Duration Result
nx run-many -t test ✅ Succeeded 13s View ↗
nx run-many -t build ✅ Succeeded 1s View ↗
nx run-many -t e2e-suite --parallel 1 ✅ Succeeded 34s View ↗
nx run-many -t test --codeCoverage ✅ Succeeded 34s View ↗
nx run-many -t build,typecheck,check-rule-docs,... ✅ Succeeded 28s View ↗
nx-cloud record -- pnpm nx sync:check ✅ Succeeded 2s View ↗
nx-cloud record -- pnpm format-check ✅ Succeeded 6s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-31 10:09:08 UTC

@JamesHenry JamesHenry mentioned this pull request May 31, 2025
Closed
1 task
@codecov Codecov
Copy link

codecov bot commented May 31, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 92.85%. Comparing base (ac01c2c) to head (c3c421e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/schematics/src/ng-add/index.ts 40.00% 3 Missing ⚠️

❌ Your patch status has failed because the patch coverage (40.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2486      +/-   ##
==========================================
- Coverage   92.91%   92.85%   -0.07%     
==========================================
  Files         200      200              
  Lines        4165     4169       +4     
  Branches      972      973       +1     
==========================================
+ Hits         3870     3871       +1     
- Misses        227      229       +2     
- Partials       68       69       +1
Flag Coverage Δ
unittest 92.85% <40.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/schematics/src/ng-add/index.ts 73.25% <40.00%> (-2.36%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JamesHenry JamesHenry merged commit 74a854c into main May 31, 2025
7 of 8 checks passed
@JamesHenry JamesHenry deleted the eslint-js branch May 31, 2025 10:25
igord pushed a commit to tcorral/angular-eslint that referenced this pull request Jun 1, 2025
@JamesHenry @igord
fix(schematics): ensure @eslint/js and @angular-eslint/builder are al…
ca21b85 
…ways available in non-npm repos (angular-eslint#2486)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error: Could not find the '@angular-eslint/builder:lint' builder's node package.
1 participant
@JamesHenry