fix(eslint-plugin): [no-uncalled-signals] handle direct signal calls in member expressions #2491
+130
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in member expressions Fixes issue where `this.test()` was incorrectly flagged as an uncalled signal. The rule now properly detects when an identifier is the property of a MemberExpression that is being called. Fixes #2490 🤖 Generated with [Claude Code](https://claude.ai/code) Co-authored-by: JamesHenry <JamesHenry@users.noreply.github.com>
|
View your CI Pipeline Execution ↗ for commit f1a48bb.
☁️ Nx Cloud last updated this comment at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2491 +/- ##
=======================================
Coverage 92.91% 92.91%
=======================================
Files 200 200
Lines 4220 4223 +3
Branches 993 995 +2
=======================================
+ Hits 3921 3924 +3
Misses 230 230
Partials 69 69
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue where
this.test()was incorrectly flagged as an uncalled signal.The rule now properly detects when an identifier is the property of a
MemberExpression that is being called.
Fixes #2490
Generated with Claude Code