Skip to content

Conversation

andreww2012
Copy link
Contributor

prefer-contextual-for-variables rule currently allows extra properties to be passed in options object, which should not be allowed. This makes it easier for typos in rule options to go unnoticed.

This PR simply disallows extra properties in this rule's schema.

Copy link

nx-cloud bot commented Jul 21, 2025

View your CI Pipeline Execution ↗ for commit 73f7dbc

Command Status Duration Result
nx run-many -t e2e-suite --parallel 1 ✅ Succeeded 34s View ↗
nx run-many -t test --codeCoverage ✅ Succeeded 1m 13s View ↗
nx run-many -t build,typecheck,check-rule-docs,... ✅ Succeeded 36s View ↗
nx-cloud record -- pnpm nx sync:check ✅ Succeeded 2s View ↗
nx-cloud record -- pnpm format-check ✅ Succeeded 5s View ↗
nx run-many -t test ✅ Succeeded 31s View ↗
nx run-many -t build ✅ Succeeded 15s View ↗

☁️ Nx Cloud last updated this comment at 2025-08-02 13:05:32 UTC

@andreww2012 andreww2012 force-pushed the fix/disallow-extra-properties-in-rule-options branch from 360ebce to c1c6ac4 Compare July 21, 2025 12:07
@JamesHenry JamesHenry merged commit 91a01e1 into angular-eslint:main Aug 2, 2025
8 checks passed
@JamesHenry
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants