feat(eslint-plugin-template): add rule no-empty-control-flow #2592
+1,198
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit 64a35c8
☁️ Nx Cloud last updated this comment at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2592 +/- ##
==========================================
+ Coverage 92.89% 92.93% +0.03%
==========================================
Files 207 209 +2
Lines 4378 4400 +22
Branches 1017 1023 +6
==========================================
+ Hits 4067 4089 +22
Misses 241 241
Partials 70 70
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
JamesHenry
reviewed
Jul 21, 2025
packages/eslint-plugin-template/src/rules/no-empty-control-flow.ts
Outdated
Show resolved
Hide resolved
JamesHenry
requested changes
Jul 21, 2025
JamesHenry
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2349
This rule is similar to ESLint's no-empty and no-empty-function rules.
If a control flow block is empty, it's probably left over from some incomplete refactoring, or added by mistake.
This rule has does not have a fixer because removing the empty block is not necessarily the correct solution.
Examples of invalid code:
@if (condition) { } @for (item of items: track $index) { } @for (item of items: track $index) { {{ item }} } @empty { } <!-- The above @empty block is unnecessary. -->