Skip to content

docs(readme): Add a more explicit advice for compiling native add-ons #2282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 5, 2016
Merged

Conversation

nstepien
Copy link
Contributor

@nstepien nstepien commented Oct 5, 2016

The node-gyp prerequisite was not making it clear that it is related to the npm install part of the Usage guide.

The node-gyp prerequisite was not making it clear that it is related to the npm install part of the Usage guide.
@Awk34 Awk34 merged commit 4d6329d into angular-fullstack:master Oct 5, 2016
@Awk34
Copy link
Member

Awk34 commented Oct 5, 2016

  • [give me a break] My commit(s) follow the AngularJS commit message guidelines

@MayhemYDG we require a specific commit message style because our changelog is automatically generated based on that specific commit message style

@nstepien nstepien deleted the patch-1 branch October 5, 2016 15:25
@nstepien
Copy link
Contributor Author

nstepien commented Oct 5, 2016

I understand that, but it's still daunting when I just want to edit a few lines in the readme.

@Awk34
Copy link
Member

Awk34 commented Oct 5, 2016

:D Maybe I'll add a simpler version to the project's docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants